Set default region back to empty string #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For non-documented reason we switched from having default value for region empty string to value RegionOne (in tag v0.4.0). RegionOne is default region name in Openstack, but this doesn't justify leaving region to default to this value. Having region as empty string makes the gophercloud library to pick first found region in the catalog. This can cause potential backwards compatibility issues, which are however very unlikely. Negative impact of having region default to RegionOne is that it makes the plugin to not work in case user relies on region specified in clouds.yaml. This also looks slightly tricky as region in clouds.yaml doesn't neccesarilly mean that that region should be configured in Cinder. This change and additional test displays the behavior. Signed-off-by: Ondrej Vasko <[email protected]>
Lirt
changed the title
Signed-off-by: Ondrej Vasko <[email protected]>
Signed-off-by: Ondrej Vasko <[email protected]>
Lirt
force-pushed
the
enh/unset-default-region
branch
2 times, most recently
from
eaa366c
to
321b72f
Compare
Signed-off-by: Ondrej Vasko <[email protected]>
Lirt
force-pushed
the
enh/unset-default-region
branch
from
321b72f
to
a6ce769
Compare
Lirt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-documented reason we switched from having default value for region empty string to value RegionOne (in tag v0.4.0). RegionOne is default region name in Openstack, but this doesn't justify leaving region to default to this value.
Having region as empty string makes the gophercloud library to pick first found region in the catalog. This can cause potential backwards compatibility issues, which are however very unlikely.
Negative impact of having region default to RegionOne is that it makes the plugin to not work in case user relies on region specified in clouds.yaml. This also looks slightly tricky as region in clouds.yaml doesn't neccesarilly mean that that region should be configured in Cinder.
This change and additional test displays the behavior.
Closes #109