Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement updated design notification banners #7

Merged
merged 13 commits into from
May 7, 2024

Conversation

liquidely
Copy link
Contributor

@liquidely liquidely commented May 2, 2024

This will apply the new design to all wikis!

In this PR:

image
image

Closes ticket
Can be tested here

PR to remove SiteNotices.js Liquipedia/Lua-Modules#4249

@iMarbot
Copy link
Contributor

iMarbot commented May 2, 2024

You might already be aware, but if you're not, to fix the CI pipeline: Liquipedia/ResourceLoaderArticles@d23ef7c

@liquidely
Copy link
Contributor Author

You might already be aware, but if you're not, to fix the CI pipeline: Liquipedia/ResourceLoaderArticles@d23ef7c

I didn't know yet, thanks a lot!

@liquidely liquidely requested a review from FO-nTTaX May 2, 2024 12:48
@liquidely liquidely requested a review from KilMer56 May 2, 2024 12:52
@liquidely liquidely changed the title Draft: Feature/128 implement notification banners Implement updated design notification banners May 2, 2024
@liquidely liquidely marked this pull request as ready for review May 2, 2024 12:57
@FO-nTTaX
Copy link
Member

FO-nTTaX commented May 2, 2024

We should probably add js stylechecking via eslint, we also should get a migration to remove the color (style) column from the database.

@liquidely
Copy link
Contributor Author

We should probably add js stylechecking via eslint, we also should get a migration to remove the color (style) column from the database.

Added eslint

Copy link
Contributor

@iMarbot iMarbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for cleaner ESLint config using ES2020 instead.


Also, I know there's no jQuery in this project, but if we ever wanted to use any, down the road, would be useful to add (then or now) it to package.json so that the jquery settings in the linter actually do something and to provide IDE syntax highlighting and static analysis.

.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
@FO-nTTaX FO-nTTaX requested a review from KilMer56 May 7, 2024 12:40
@FO-nTTaX FO-nTTaX merged commit 32a5986 into master May 7, 2024
6 checks passed
@FO-nTTaX FO-nTTaX deleted the feature/128-implement-notification-banners branch May 7, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants