Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for all forms of display name #4797

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Check for all forms of display name #4797

wants to merge 3 commits into from

Conversation

robbai
Copy link
Collaborator

@robbai robbai commented Sep 28, 2024

Summary

Check for alternative storage names of "display name" since they are not always the same

How did you test this change?

/dev

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a fan, annotations state that the function is expecting standardPlayer and not match2player or an abitrary table

@robbai
Copy link
Collaborator Author

robbai commented Sep 29, 2024

not a fan, annotations state that the function is expecting standardPlayer and not match2player or an abitrary table

I've changed it now to only be used where necessary

@hjpalpha
Copy link
Collaborator

alternative solution (personally do not have a preference, just leaving it here as an option; untested fwiw):

---@param opponent table
---@return boolean
function MatchFunctions._checkForNonEmptyOpponent(opponent)
	return not Opponent.isTbd(Opponent.fromMatch2Record(opponent))
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants