feat(match2) Add map points input to Halo #4793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Sep 25, 2024
mbergen
commented
Sep 27, 2024
hjpalpha
reviewed
Sep 27, 2024
hjpalpha
approved these changes
Sep 29, 2024
Rathoz
reviewed
Oct 1, 2024
Co-authored-by: Rikard Blixt <[email protected]>
Rathoz
reviewed
Oct 1, 2024
Comment on lines
+147
to
+148
| local getScoreValue = function(opponentIndex) | ||
| local score = game.scores[opponentIndex] |
There was a problem hiding this comment.
Suggested change
| local getScoreValue = function(opponentIndex) | |
| local score = game.scores[opponentIndex] | |
| local displayScore = function(opponentIndex) | |
| local score = DisplayHelper.MapScore(game.scores[opponentIndex], opponentIndex, game.resultType, game.walkover, game.winner) |
Rathoz
reviewed
Oct 1, 2024
Comment on lines
+166
to
+169
| :node(DisplayHelper.MapScore( | ||
| getScoreValue(1), | ||
| 1, game.resultType, game.walkover, game.winner | ||
| )) |
There was a problem hiding this comment.
Suggested change
| :node(DisplayHelper.MapScore( | |
| getScoreValue(1), | |
| 1, game.resultType, game.walkover, game.winner | |
| )) | |
| :node(displayScore(1)) |
Rathoz
reviewed
Oct 1, 2024
Comment on lines
+173
to
+176
| :node(DisplayHelper.MapScore( | ||
| getScoreValue(2), | ||
| 2, game.resultType, game.walkover, game.winner | ||
| )) |
There was a problem hiding this comment.
Suggested change
| :node(DisplayHelper.MapScore( | |
| getScoreValue(2), | |
| 2, game.resultType, game.walkover, game.winner | |
| )) | |
| :node(displayScore(2)) |
Rathoz
reviewed
Oct 1, 2024
Comment on lines
+149
to
+151
| if not score then | ||
| return | ||
| end |
There was a problem hiding this comment.
Suggested change
| if not score then | |
| return | |
| end |
Not needed with the other changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows input of
{{Map| ... |points1=|points2=}}to be concatenated in output.Requested on discord
How did you test this change?
dev