feat(widget): widget v2

[Rathoz]

Summary

Widget v2 contain two main changes.

1. Structural change to the Widgets are made
2. Replacement of Customizables & Injectors with Contexts

Thanks to these changes in combination, the Inversion of Control becomes a lot better.

Contexts

Add support for the provider pattern, similiar to that of react in our Widgets. Contexts allow for a clearer hierarchy, and smooth implementations. Contexts allows for any data, allowing for, for instance, more specific data. One could make a context that implements just the content of the role cell on Infobox Person instead of having to do the entire cell, as an example instance, allowing for better fine-tuned control, and less broad overrides. Additionally it doesn't have the implementation overhead with injectors that more complex Widgets ran into.

Widget changes

The biggest changes:

• uses render() instead of make(children) and makeChildren(injector)
• all parameters goes into a prop field, handled automatically from the Widget Base (Module:Widget)
• Support for what to render if there's an error, such as wrapper (:getDerivedStateFromError())
• Backwards compatibility with WidgetV1 through legacy handling

The impact and flexibility thanks to these changes makes a huge difference, especially the first one. The second one make the boilerplate needed to create a widget a lot smaller.

Squad

The PR also replaces the Squad feature to Widget v2

Code

This is how a wiki-custom for Squad render can look like

return SquadContext.RoleName{value = 'Position', children = {
  SquadTable{
    title = 'My Title',
    type = SquadType.ACTIVE,
    children = {
      --
    },
}

Future

Not super pleased with the context's default handling, but it works for now. The way it works here makes it very simple to convert existing customizables. Maybe for later

How did you test this change?

dev and busted

[hjpalpha]

still some failed tests ;)

generally okay imo

[Rathoz]

still some failed tests ;)

generally okay imo

The failed goldens are just a change from inline styling to css