Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative 2 for #4555 #4572

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Alternative 2 for #4555 #4572

wants to merge 3 commits into from

Conversation

hjpalpha
Copy link
Collaborator

Summary

How did you test this change?

@hjpalpha hjpalpha mentioned this pull request Aug 19, 2024
Closed
mbergen
mbergen approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@mbergen mbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the cleanest way to solve this issue.

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Aug 19, 2024 •
edited
Loading

fyi:
IMG_4106

@mbergen
Copy link
Collaborator

mbergen commented Aug 19, 2024 •
edited
Loading

Sure, we can do that to control null vs empty table/array, but I still think the change from this PR would make sense:
The current implementation would never serialize a proper JSON array unless asArray is set.
When it is not set, any array will actually be serialized as a table. Unless it is empty - which would result in a JSON array? sounds inconsistent and/or broken.

@hjpalpha
Copy link
Collaborator Author

tend to agree, but will most likely not have the time for it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbergen mbergen mbergen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjpalpha @mbergen