Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve localdev doc and fold it into the main README #20

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

notartom
Copy link
Member

Closes issue #11

@notartom
Copy link
Member Author

notartom commented Dec 27, 2023

@redrun45 your review/feedback would be appreciated :) The guide itself is hopefully improvemed, but I've also invested some elbow grease into localdev itself, and even into some CI to dpeloy it on every PR.

@redrun45
Copy link
Contributor

redrun45 commented Dec 27, 2023 via email

@notartom
Copy link
Member Author

I particularly like the new caveats/disclaimers section. A succinct statement of what I should expect from a successful deployment.

👍

Only one step I'd add so far: adding the localdev target IP to inventory.yaml before the ansible-playbook command.

Good point, I've added that in the most recent version.

@notartom
Copy link
Member Author

On the basis that something is better than nothing, I'm going to merge this. If there are further comments/suggestions/feedback, please open new issues :)

@notartom notartom merged commit a6db5ff into LibriVox:master Dec 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants