Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in facebook pixel for tracking #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Jay2Base
Copy link

going to try a bit of facebook advertising for the developer roles

@@ -0,0 +1,14 @@
<!-- Facebook Pixel Code -->
<script>
!function(f,b,e,v,n,t,s){if(f.fbq)return;n=f.fbq=function(){n.callMethod?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in facebookAdTracking.js ;)

@kevbite
Copy link
Contributor

kevbite commented Jan 26, 2016

Can we just use tag manager for this?

@terrawheat
Copy link
Contributor

The ViewContent track event should go after the content - for both loading speed and so its actually true and they have viewed the content.

@kevbite we could use Tag Manager to deliver the initial payload of FB stuff, I think the actual track trigger needs to be in our code.

@@ -0,0 +1,14 @@
<!-- Facebook Pixel Code -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No HTML comments!

sakisk pushed a commit that referenced this pull request Feb 25, 2016
@kevbite
Copy link
Contributor

kevbite commented Apr 12, 2016

tumbleweed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants