Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix includeWhiteChars option #589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fkirc
Copy link

@fkirc fkirc commented Oct 21, 2020

Currently, we do not receive any whitespace-characters, even if includeWhiteChars is set to true.
This might be also related to #582.

One more sidenote:
If there is an overload of pull requests, please let me know whether this library is still maintained, or whether you are looking for a new maintainer.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.74% when pulling be5e025 on fkirc:include_whitespace into 1832e0b on Leonidas-from-XIV:master.

@fkirc
Copy link
Author

fkirc commented Oct 29, 2020

More generally, it would be nice to have some documentation about whitespace-preservation.
My use case is attranslate, a new tool to translate apps and websites: https://github.com/fkirc/attranslate
For translations, we would like to modify an existing XML-file with as little changes as possible, which means to preserve whitespace and comments.

@ivanzwb
Copy link

ivanzwb commented Nov 4, 2020

Will this change merged? We also encounter this issue.

@fkirc
Copy link
Author

fkirc commented Nov 4, 2020

To be honest, I believe that nothing will be merged.
You could use my fork that includes this fix, which is also used by https://github.com/fkirc/attranslate.
Or you could make your own fork.

@Leonidas-from-XIV
Copy link
Owner

Leonidas-from-XIV commented Nov 4, 2020

If there is an overload of pull requests, please let me know whether this library is still maintained, or whether you are looking for a new maintainer.

I maintain it very sporadically. The problem with just accepting pull requests is that they add even more features which makes maintaining it even harder so I am somewhat hesitant (given the overall bad shape that the code already is in) and people often don't care about breaking things without considering that there are a ton of dependents that rely on how it is working at the moment.

Like, e.g. this PR is missing tests so whether this functionality works or not is not being evaluated in any automated way and the sheer amount of possible interactions with other options is unclear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants