Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread pool #149

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

OfekShochat
Copy link
Contributor

@OfekShochat OfekShochat commented Mar 8, 2021

changes:

  • add thread pool for multi gpu use without multiple instances of client
  • add quiet mode which suppresses serverParams print and Args print
  • cons: adds 2 additional dependencies: "github.com/shettyh/threadpool" (threadpool) and "github.com/jaypipes/ghw" (gpu number) (so appveyor.yml was updated) and increase executable size from 7577kb to 8164kb

known issues:

  • in task, if it encounters an error other thread will not stop. can be implemented with bool var that you check in every iteration of the for loop in main(), or using callable task (https://github.com/shettyh/threadpool) that also returns a future and use future.IsDone(). tho this is harder and probably messier.

@OfekShochat OfekShochat marked this pull request as draft March 14, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant