Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

LIVE-2162 Solana fixes after initial staking #4969

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2022

🦒 Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-2162

💻 Description / Demo (image or video)

Specs of the changes are described here: https://docs.google.com/document/d/1QvlLnoLBkXZ3xul7cHajYzqVjolSTj0tJ64YPfkjvG8/edit

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

* solana invert validator commision and total stake

* solana conditionaly hide ledger by figment TC when staking

* solana add use all amount stake warning

* solana refactor delegation CTA

* solana disable hover on non choosable validators

* solana fix renamed useValidators in LLC

* solana fix lint issues
@github-actions
Copy link

github-actions bot commented May 9, 2022

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 23.46% 38/162
🔴 Branches 20.51% 8/39
🔴 Functions 3.64% 2/55
🔴 Lines 24.16% 36/149

Test suite run success

2 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 54102a4

static/i18n/en/app.json Outdated Show resolved Hide resolved
@ghost ghost marked this pull request as ready for review May 13, 2022 15:05
@ghost ghost requested review from a team as code owners May 13, 2022 15:05
@ghost ghost self-requested a review as a code owner May 13, 2022 15:43
@ghost
Copy link
Author

ghost commented May 17, 2022

/generate-screenshots

@github-actions
Copy link

@ghost ghost self-requested a review as a code owner May 17, 2022 08:51
@ghost
Copy link
Author

ghost commented May 17, 2022

/generate-screenshots

@github-actions
Copy link

@ghost ghost added the feature ready label May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants