Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

fix/market details screen nav #4945

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Apr 26, 2022

🦒 Context (issues, jira)

💻 Description / Demo (image or video)

Fixes issue on navigation on market details page.
Now data shows up instantly + double breadcrumb fix + removal of forced refresh when coming back to main list page.

fix-market-2022-04-26_08.45.56.mp4

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

@LFBarreto LFBarreto requested a review from a team as a code owner April 26, 2022 06:46
@github-actions
Copy link

github-actions bot commented Apr 26, 2022

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 23.46% 38/162
🔴 Branches 20.51% 8/39
🔴 Functions 3.64% 2/55
🔴 Lines 24.16% 36/149

Test suite run success

2 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 3116662

@LFBarreto
Copy link
Contributor Author

/generate-screenshots

@github-actions
Copy link

@juan-cortes
Copy link
Contributor

CI is not running, does this have a linked Jira task?

@ofreyssinet-ledger
Copy link
Contributor

the branch name should be bugfix/... no?

@LFBarreto LFBarreto force-pushed the fix/market-details-screen-nav branch from 25768f2 to 3116662 Compare May 18, 2022 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants