Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-2380 Update Cosmos minimum Nano app version to v2.34.4 #1966

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2022

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-2380

Description / Usage

Product request to enforce minimum app version 2.34.4 for Cosmos Nano app

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ghost ghost self-requested a review as a code owner May 17, 2022 15:32
@ghost ghost self-assigned this May 17, 2022
@vercel
Copy link

vercel bot commented May 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ✅ Ready (Inspect) Visit Preview May 17, 2022 at 3:32PM (UTC)

@ghost ghost added the feature ready label May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1966 (00ecc00) into develop (2298702) will decrease coverage by 9.20%.
The diff coverage is n/a.

❗ Current head 00ecc00 differs from pull request most recent head 5cf8ccc. Consider uploading reports for the commit 5cf8ccc to get more accurate results

@@             Coverage Diff             @@
##           develop    #1966      +/-   ##
===========================================
- Coverage    68.57%   59.37%   -9.21%     
===========================================
  Files          546      511      -35     
  Lines        23426    21017    -2409     
  Branches      6165     5666     -499     
===========================================
- Hits         16064    12478    -3586     
- Misses        7319     8517    +1198     
+ Partials        43       22      -21     
Impacted Files Coverage Δ
src/apps/support.ts 31.81% <ø> (-68.19%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (-75.39%) ⬇️
src/families/bitcoin/networks.ts 5.88% <0.00%> (-74.51%) ⬇️
src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
src/hw/signTransaction/ripple.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/celo/js-buildTransaction.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/elrond/api/sdk.ts 22.64% <0.00%> (-71.70%) ⬇️
src/families/solana/js-broadcast.ts 28.57% <0.00%> (-71.43%) ⬇️
... and 167 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2298702...5cf8ccc. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants