This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
LL-4373 Discard existing ops on sync if blacklist has changed #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ledgerhq-old/ledger-live-common/cgw2rce1j |
|
LGTM to me. 2 things to polish as we discussed:
|
Add testing for blacklisted feature
|
Should be fine now, I added test coverage for the blacklistedTokenids functionality |
|
we'll merge #963 first and then we'll regen the snapshots here. |
|
we can actually move on at putting the latest snapshots of the CI. the other PR is not ready yet. lemme do it |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the js bridge rewrite blacklisted tokens could no longer be shown without a clear cache, since we wo uld only fetch from a given block height. This addresses that by setting a cache id at the account level and dismissing the existing ops if it doesnt match the blacklist settings.
https://ledgerhq.atlassian.net/browse/LL-4373