Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app-load-params-db.json to add support for Acre #266

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Update app-load-params-db.json to add support for Acre #266

merged 3 commits into from
Oct 9, 2024

Conversation

keiff3r
Copy link
Contributor

@keiff3r keiff3r commented Oct 8, 2024

No description provided.

@tdejoigny-ledger
Copy link
Contributor

hello @keiff3r

ty for you PR.
Could you please:

  • remove the "path_slip21": "LEDGER-Wallet policy" line
  • remove the target "nanoS" (and same if the ledger toml in your app if not already the case)
  • fix the lint issue

@keiff3r
Copy link
Contributor Author

keiff3r commented Oct 9, 2024

Hello @tdejoigny-ledger,

thank you for the feedback. I made the requested changes

@tdejoigny-ledger tdejoigny-ledger merged commit c2538c4 into LedgerHQ:main Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keiff3r @tdejoigny-ledger