fix: fix the issue of briefly appearing on the app homepage after con…

…firming the transaction. (#61)
LedgerHQ · Jul 23, 2024 · a526178 · a526178
1 parent 34fe77d
commit a526178
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/ui/nbgl_address.c b/src/ui/nbgl_address.c
@@ -28,12 +28,12 @@
 #include "action/validate.h"
 
 static void review_choice(bool confirm) {
-    validate_pubkey(confirm);
     if (confirm) {
         nbgl_useCaseReviewStatus(STATUS_TYPE_ADDRESS_VERIFIED, ui_menu_main);
     } else {
         nbgl_useCaseReviewStatus(STATUS_TYPE_ADDRESS_REJECTED, ui_menu_main);
     }
+    validate_pubkey(confirm);
 }
 
 int ui_display_address(void) {

diff --git a/src/ui/nbgl_hash.c b/src/ui/nbgl_hash.c
@@ -66,8 +66,8 @@ static void prepare_page(void) {
 }
 
 static void reject_confirmation(void) {
-    ui_action_validate_transaction(false);
     nbgl_useCaseStatus("Hash rejected", false, ui_menu_main);
+    ui_action_validate_transaction(false);
 }
 
 static void reject_choice(void) {
@@ -80,8 +80,8 @@ static void reject_choice(void) {
 
 static void review_choice(bool confirm) {
     if (confirm) {
-        ui_action_validate_transaction(true);
         nbgl_useCaseStatus("Hash signed", true, ui_menu_main);
+        ui_action_validate_transaction(true);
     } else {
         reject_choice();
     }

diff --git a/src/ui/nbgl_transaction.c b/src/ui/nbgl_transaction.c
@@ -231,8 +231,8 @@ static bool display_transaction_page(uint8_t page, nbgl_pageContent_t *content)
 }
 
 static void reject_tx_confirmation(void) {
-    ui_action_validate_transaction(false);
     nbgl_useCaseReviewStatus(STATUS_TYPE_TRANSACTION_REJECTED, ui_menu_main);
+    ui_action_validate_transaction(false);
 }
 
 static void reject_tx_choice(void) {
@@ -245,8 +245,8 @@ static void reject_tx_choice(void) {
 
 static void review_tx_choice(bool confirm) {
     if (confirm) {
-        ui_action_validate_transaction(true);
         nbgl_useCaseReviewStatus(STATUS_TYPE_TRANSACTION_SIGNED, ui_menu_main);
+        ui_action_validate_transaction(true);
     } else {
         reject_tx_choice();
     }
@@ -271,8 +271,8 @@ static void review_tx_start(void) {
 }
 
 static void reject_auth_confirmation(void) {
-    ui_action_validate_transaction(false);
     nbgl_useCaseStatus("Soroban Auth rejected", false, ui_menu_main);
+    ui_action_validate_transaction(false);
 }
 
 static void reject_auth_choice(void) {
@@ -285,8 +285,8 @@ static void reject_auth_choice(void) {
 
 static void review_auth_choice(bool confirm) {
     if (confirm) {
-        ui_action_validate_transaction(true);
         nbgl_useCaseStatus("Soroban Auth signed", true, ui_menu_main);
+        ui_action_validate_transaction(true);
     } else {
         reject_auth_choice();
     }