-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Cards to v10.291. #2370
base: v10/non-inferring-data-fields
Are you sure you want to change the base?
Updated Cards to v10.291. #2370
Conversation
…Foundry-Developers/foundry-vtt-types into v10/non-inferring-data-fields_client_data_documents_cards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor things.
| ConstructorDataType<foundry.data.CardsData> | ||
| (ConstructorDataType<foundry.data.CardsData> & Record<string, unknown>) | ||
>, | ||
data: Array<ConstructorDataType<CardsData> | (ConstructorDataType<CardsData> & Record<string, unknown>)>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be simplified even more, by using BaseCards.ConstructorData
. We would then either need to introduce a generic parameter on the Cards
class for the different system types or leave it open and add a union of all known types as a default to the ConstructorData
. I think once we are done, we won't need ConstructorDataType
at all anymore.
The same goes for the other occurrences. We can check each time whether it's ConstructorData
, UpdateData
or Properties
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With that said, should I take further action for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please.
…Foundry-Developers/foundry-vtt-types into v10/non-inferring-data-fields_client_data_documents_cards
Closes #1955