Fixed pt-br translation and extra string identifiers #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some grammatical errors on the Brazilian Portuguese translation and added a few string identifiers to expand the translation of this module.
joevaughan
reviewed
Sep 24, 2022
There was a problem hiding this comment.
Great changes @eduardopato41
However, with the addition of new fields, and only adding them to en.json and pt-BR.json, you risk breaking things for all the other localisations. Could you perhaps add the additional fields in en.json to the other translations (in english of course, we can sort you the localization of those in a future release) and re-commit?
|
Just committed the additional fields to the other translations ✌️ |
joevaughan
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Fantastic @eduardopato41 - We will need to get these translated in time but for now at least we can build off this base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some grammatical errors on the Brazilian Portuguese translation and added a few string identifiers to expand the translation of this module.