Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganisation #53

Merged
merged 51 commits into from
Sep 10, 2024
Merged

Reorganisation #53

merged 51 commits into from
Sep 10, 2024

Conversation

LeChatP
Copy link
Owner

@LeChatP LeChatP commented Sep 10, 2024

No description provided.

LeChatP and others added 30 commits August 29, 2024 11:55
Common sources are now in a separate crate. This has the advantage to avoid many "unused" warnings. Indeed as chsr uses some calls that sr don't use, it raise this warning. And as the same with sr. So many unused warnings were wrongly reported.

I started to make deployment work, as sr and chsr seems to be well-tested and made some security checks.

For now, deployment is WIP.
This work aims to code the installation process to take into account many parameters that are complex to manipulate using shell, but also avoid some dependencies that are only used for the installation process.

This work should also simplify deployment on many distributions, while applying the principle of least privilege.

However, one last question is about the dependency management, as it requires rust, we still need a shell script to install rust toolchains. As capable requires nighly,  and sr requires stable>=1.70, it may requires both toolchains for a clean release binary.
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 58.04196% with 120 lines in your changes missing coverage. Please review.

Project coverage is 68.92%. Comparing base (c08baff) to head (3ba93ce).
Report is 266 commits behind head on develop.

Files with missing lines Patch % Lines
rar-common/src/util.rs 56.52% 80 Missing ⚠️
rar-common/src/database/options.rs 70.37% 8 Missing ⚠️
rar-common/src/database/finder.rs 30.00% 7 Missing ⚠️
rar-common/src/plugin/mod.rs 0.00% 4 Missing ⚠️
src/sr/main.rs 20.00% 4 Missing ⚠️
src/sr/timeout.rs 42.85% 4 Missing ⚠️
rar-common/src/database/structs.rs 57.14% 3 Missing ⚠️
rar-common/src/database/versionning.rs 40.00% 3 Missing ⚠️
src/chsr/cli/process/json.rs 88.88% 3 Missing ⚠️
rar-common/src/api.rs 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #53       +/-   ##
============================================
+ Coverage    41.03%   68.92%   +27.88%     
============================================
  Files           23       27        +4     
  Lines         6170     2819     -3351     
============================================
- Hits          2532     1943      -589     
+ Misses        3638      876     -2762     
Flag Coverage Δ
admin-unittests 68.60% <56.29%> (?)
unittests 68.78% <58.04%> (+27.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeChatP LeChatP merged commit 0bb9301 into develop Sep 10, 2024
6 checks passed
@LeChatP LeChatP deleted the reorganisation branch September 10, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant