This repository has been archived by the owner on Feb 7, 2022. It is now read-only.
added --silent and --silent-unchanged flag, regarding #47 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LINKIWI
reviewed
May 18, 2020
| @@ -34,10 +35,26 @@ def load_arguments(): | |||
| parser.add_argument('--configure', action='store_true', help='Interactively configure the account and domain for the DDNS updates.') | |||
| parser.add_argument('--update-now', action='store_true', help='Update DNS records right now.') | |||
| parser.add_argument('--debug', action='store_true', help='Print detailed debug output.') | |||
| parser.add_argument('--silent', action='store_true', help='Do not print any output.') | |||
| parser.add_argument('--silent-unchanged', action='store_true', help='Only print DNS changes / warning / errors.') | |||
There was a problem hiding this comment.
Per the discussion in the other issue I would recommend removing this option entirely since it doesn't add much value; it's not really "silent" and just feels like a raised log level.
There was a problem hiding this comment.
Well, request at Issue #47 is:
Running once a day at midnight with local mail results in the same repeated message of "no changes", but with a quiet option the command would only produce output (and hence an email) if a change was made.
That sounds like my --silent-unchanged flag.
Why not offer the option if someone wants it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacement for #48
regarding #47
this adds a
--silentflag that sets the log level above all standard log levels.also adds a
--silent-unchangedflag that sets the log level to the custom levelCHANGE(21, one above INFO). Using this flag, the script will only output warning, errors, DNS changes.