Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: will now work with canary-release plugin #41

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

hafstroem
Copy link
Contributor

About the PR

This PR will allow the aws-request-signing plugin to work in conjunction with the Canary Release plugin. It achieves this by lowering the priority of the aws-request-signing plugin so that the signing will happen after the Canary Release plugin has determined the which host is the destination of the request. Furthermore a small code change will pick up the original service destination from an internal data structure that honors changes applied by the Canary Release plugin

Changelog

  • Add: Added support for co-existence with Canary Release plugin!

Definition of Done - are you done?

Testing

  • Has been tested locally.

Other

  • Documentation has been updated (if applicable)
  • No linting errors

@hafstroem hafstroem self-assigned this Aug 8, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! Your first PR? That's just totally AWESOME! Keep 'em coming! 🙌 Allow the community some time to give you feedback and engage with us to make your contribution stand out even better.

@hafstroem hafstroem merged commit 4616da0 into main Aug 9, 2024
4 checks passed
@hafstroem hafstroem deleted the feat/canary-integration branch August 9, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants