Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend AWS policy #187

Merged
merged 9 commits into from
Aug 15, 2024
Merged

feat: extend AWS policy #187

merged 9 commits into from
Aug 15, 2024

Conversation

Gadam8
Copy link
Contributor

@Gadam8 Gadam8 commented Jul 1, 2024

About the PR

The current AWS policy binding configuration doesn't match what is offered by AWS when configuring IAM policies. Condition and Resource are missing and Principal isn't fully fleshed out. e.g. https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_condition.html#Condition-multiple-conditions & https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_principal.html. This PR addresses this by extending the binding configuration for SNS and SQS.

See related JSON bindings PR here - asyncapi/spec-json-schemas#553

Changelog

  • Add: Resource property to AWS Statement class for both SNS and SQS
  • Add: Condition property to AWS Statement class for both SNS and SQS
  • Amend: Changed type for Principal property in AWS Statement to allow for full implementation

Related Issues

N/A

@VisualBean
Copy link
Collaborator

Great work on the spec side so far! Let me know if you need help on the implementation side 👍

@Gadam8
Copy link
Contributor Author

Gadam8 commented Jul 23, 2024

Great work on the spec side so far! Let me know if you need help on the implementation side 👍

Thank you! I've just pushed some changes to align with the recent spec changes. Would appreciate a review and any feedback 🙏

@VisualBean
Copy link
Collaborator

Only have a few minor things, otherwise its looking great!

@VisualBean
Copy link
Collaborator

@Gadam8 looks great in its current iteration.
What do you think?

@Gadam8
Copy link
Contributor Author

Gadam8 commented Aug 15, 2024

@Gadam8 looks great in its current iteration. What do you think?

Thank you! Yeah I'm happy with how these changes look 👍 Happy to proceed

@VisualBean VisualBean merged commit 9cc759f into LEGO:main Aug 15, 2024
5 checks passed
@Gadam8 Gadam8 deleted the extend-aws-policy branch August 16, 2024 08:13
@Gadam8
Copy link
Contributor Author

Gadam8 commented Aug 16, 2024

Thanks for the merge @VisualBean! What's the process for releasing a new version? Is it possible to get a beta release now? Thanks 👍

@VisualBean
Copy link
Collaborator

VisualBean commented Aug 16, 2024

@Gadam8 looks great in its current iteration. What do you think?

Thank you! Yeah I'm happy with how these changes look 👍 Happy to proceed

Yeah ill rebase it to the vnext branch and release a new beta nuget (probably before end of day today).

Edit: Ive pushed a beta release with the new binding changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants