feat: added new topic configuration properties #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @VisualBean, it would be great if you could review this PR. It's a small one. |
|
Sure, it's in the spec. 👍 If you ever refactor the binding, consider making a VendorConfiguration map, so vendor stuff isn't tied directly to the base binding (otherwise it'll end up being littered with Configs for different vendors). Anyway - looks good |
VisualBean
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Kafka topic configuration properties have been updated in the asyncapi/bindings repo. Please see the latest version here.
To address those changes I've added 4 new properties to the topic configuration object.
Changelog
Please let me know if you need more details about the change. Thanks!