remove redundant ctors

LEGO · Feb 26, 2024 · 963a931 · 963a931
1 parent 5c18d93
commit 963a931
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 57 deletions.
diff --git a/src/LEGO.AsyncAPI/Models/Any/AsyncApiAny.cs b/src/LEGO.AsyncAPI/Models/Any/AsyncApiAny.cs
@@ -40,54 +40,6 @@ public AsyncApiAny(object obj)
             this.node = JsonNode.Parse(JsonSerializer.Serialize(obj, this.options));
         }
 
-        /// <summary>
-        /// Initializes a new instance of the <see cref="AsyncApiAny"/> class.
-        /// </summary>
-        /// <param name="dictionary">The dictionary.</param>
-        public AsyncApiAny(Dictionary<string, AsyncApiAny> dictionary)
-        {
-            var jsonObject = new JsonObject();
-            foreach (var kvp in dictionary)
-            {
-                jsonObject.Add(kvp.Key, kvp.Value.node);
-            }
-
-            this.node = jsonObject;
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="AsyncApiAny"/> class.
-        /// </summary>
-        /// <param name="list">The list.</param>
-        public AsyncApiAny(List<object> list)
-        {
-            var jsonArray = new JsonArray();
-            foreach (var item in list)
-            {
-                string jsonString = JsonSerializer.Serialize(item, this.options);
-                jsonArray.Add(JsonNode.Parse(jsonString));
-            }
-
-            this.node = jsonArray;
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="AsyncApiAny"/> class.
-        /// </summary>
-        /// <param name="dictionary">The dictionary.</param>
-        public AsyncApiAny(Dictionary<string, object> dictionary)
-        {
-            var jsonObject = new JsonObject();
-            foreach (var kvp in dictionary)
-            {
-                string jsonString = JsonSerializer.Serialize(kvp.Value, this.options);
-                jsonObject.Add(kvp.Key, JsonNode.Parse(jsonString));
-            }
-
-            this.node = jsonObject;
-        }
-
-
         /// <summary>
         /// Initializes a new instance of the <see cref="AsyncApiAny"/> class.
         /// </summary>

diff --git a/test/LEGO.AsyncAPI.Tests/Models/AsyncApiAnyTests.cs b/test/LEGO.AsyncAPI.Tests/Models/AsyncApiAnyTests.cs
@@ -3,8 +3,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace LEGO.AsyncAPI.Tests
 {
@@ -22,9 +20,10 @@ public void GetValue_ReturnsCorrectConversions()
             var d = new AsyncApiAny(true);
             var e = new AsyncApiAny(new MyType("test"));
             var f = new AsyncApiAny(new List<string>() { "test", "test2"});
-            var g = new AsyncApiAny(new List<MyType>() { new MyType("test") });
-            var h = new AsyncApiAny(new Dictionary<string, int>() { { "t", 2 } });
-            var i = new AsyncApiAny(new Dictionary<string, MyType>() { { "t", new MyType("test") } });
+            var g = new AsyncApiAny(new List<string>() { "test", "test2"}.AsEnumerable());
+            var h = new AsyncApiAny(new List<MyType>() { new MyType("test") });
+            var i = new AsyncApiAny(new Dictionary<string, int>() { { "t", 2 } });
+            var j = new AsyncApiAny(new Dictionary<string, MyType>() { { "t", new MyType("test") } });
 
             // Assert
             Assert.AreEqual("string", a.GetValue<string>());
@@ -34,10 +33,12 @@ public void GetValue_ReturnsCorrectConversions()
             Assert.NotNull(e.GetValue<MyType>());
             Assert.IsNotEmpty(f.GetValue<List<string>>());
             Assert.IsNotEmpty(f.GetValue<IEnumerable<string>>());
-            Assert.IsNotEmpty(g.GetValue<List<MyType>>());
-            Assert.IsNotEmpty(g.GetValue<IEnumerable<MyType>>());
-            Assert.IsNotEmpty(h.GetValue<Dictionary<string, int>>());
-            Assert.IsNotEmpty(i.GetValue<Dictionary<string, MyType>>());
+            Assert.IsNotEmpty(g.GetValue<List<string>>());
+            Assert.IsNotEmpty(g.GetValue<IEnumerable<string>>());
+            Assert.IsNotEmpty(h.GetValue<List<MyType>>());
+            Assert.IsNotEmpty(h.GetValue<IEnumerable<MyType>>());
+            Assert.IsNotEmpty(i.GetValue<Dictionary<string, int>>());
+            Assert.IsNotEmpty(j.GetValue<Dictionary<string, MyType>>());
         }
 
         class MyType