📚 add more todo tags

Kwenta · Apr 29, 2024 · 8a5e934 · 8a5e934
1 parent 7b55d37
commit 8a5e934
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/Account.sol b/src/Account.sol
@@ -774,6 +774,7 @@ contract Account is IAccount, Auth, OpsReady {
         int256 _sizeDelta,
         uint256 _desiredFillPrice
     ) internal {
+        /// @custom:todo use _desiredFillPrice
         _imposeOrderFlowFee(_market, _sizeDelta);
 
         IPerpsV2MarketConsolidated(_market)
@@ -799,6 +800,7 @@ contract Account is IAccount, Auth, OpsReady {
         address _market,
         uint256 _desiredFillPrice
     ) internal {
+        /// @custom:todo use _desiredFillPrice
         _imposeOrderFlowFee(
             _market,
             IPerpsV2MarketConsolidated(_market).positions({

diff --git a/test/integration/orderFlowFee.behavior.t.sol b/test/integration/orderFlowFee.behavior.t.sol
@@ -150,6 +150,10 @@ contract OrderFlowFeeTest is Test, ConsolidatedEvents {
         /// 1. error is caught for each scenario where the market margin is insufficient
     }
 
+    /// @custom:todo desired fill price behaviour? floor/ceiling price behaviour? reverts? etc
+    /// @custom:todo what happens if withdrawing margin from market results in leverage exceeding allowed leverage? revert?
+    /// @custom:todo think deeply about the edge cases
+
     /// @custom:todo use atomic order flow to simplify testing
     function test_imposeOrderFlowFee_event() public {
         /// @custom:todo test the following: