Adding cmd to create new application #54
KunalSin9hAnnotations
8 errors and 8 warnings
|
lint:
internal/core/application/app.go#L104
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
lint:
internal/core/application/app.go#L112
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
lint:
internal/core/application/set.go#L20
field `applications` is unused (unused)
|
|
lint:
cmd/meltcd/app.go#L76
response body must be closed (bodyclose)
|
|
lint:
internal/core/application/spec.go#L51
ST1005: error strings should not be capitalized (stylecheck)
|
|
lint:
internal/core/application/spec.go#L55
ST1005: error strings should not be capitalized (stylecheck)
|
|
lint:
cmd/meltcd/app.go#L88
ST1005: error strings should not be capitalized (stylecheck)
|
|
lint
issues found
|
|
lint:
internal/core/application/spec.go#L25
exported: type name will be used as application.ApplicationSpec by other packages, and that stutters; consider calling this Spec (revive)
|
|
lint:
internal/core/application/app.go#L103
unused-parameter: parameter 'targetState' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/core/application/app.go#L111
unused-parameter: parameter 'targetState' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/core/application/set.go#L19
exported: type name will be used as application.ApplicationSet by other packages, and that stutters; consider calling this Set (revive)
|
|
lint:
internal/core/application/app.go#L37
exported: type name will be used as application.ApplicationHealth by other packages, and that stutters; consider calling this Health (revive)
|
|
lint:
internal/core/application/app.go#L85
empty-block: this block is empty, you can remove it (revive)
|
|
lint:
internal/core/registery.go#L18
errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive)
|
|
lint:
cmd/meltcd/util.go#L22
var-naming: don't use underscores in Go names; func error_msg should be errorMsg (revive)
|