Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1beta2 as hub version #482

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Use v1beta2 as hub version #482

merged 6 commits into from
Aug 27, 2024

Conversation

alexsnaps
Copy link
Member

@alexsnaps alexsnaps commented Aug 26, 2024

Unsure whether we want to change the controller to use v1beta2 as part of this PR or a different one...

Partially fixes #479 - need to update the controller logic to use the new API

Signed-off-by: Alex Snaps <[email protected]>
@alexsnaps
Copy link
Member Author

@guicassolato wdyt: should I add the controller changes to this PR?

@alexsnaps alexsnaps marked this pull request as ready for review August 26, 2024 17:24
@alexsnaps
Copy link
Member Author

Other than me missing something, I think we should keep this PR as one individual change, and the controller one as another... I started and it'll be quite a big change in itself... With that in mind, marking this as ready for review

Signed-off-by: Alex Snaps <[email protected]>
@guicassolato
Copy link
Collaborator

guicassolato commented Aug 26, 2024

@alexsnaps, can you please run make generate manifests?

There are still a few RBAC manifests that should not be part of this change.

Signed-off-by: Alex Snaps <[email protected]>
@alexsnaps
Copy link
Member Author

alexsnaps commented Aug 26, 2024

@alexsnaps, can you please run make generate manifests?

There are still a few RBAC manifests that should not be part of this change.

I think this is still not doing what you expect... I'm unsure what you are referencing here but make generate manifests "merely" changed these 2 lines in deepcopy 🤔

I scratched all in ./bin, but same behavior... can you try locally see if you achieve some other results?

Signed-off-by: Guilherme Cassolato <[email protected]>
- apiGroups:
- operator.authorino.kuadrant.io
resources:
- authorinos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pushing a commit. IDK how this ended up here. This particular permission belongs to Authorino Operator, not to Authorino.

Copy link
Collaborator

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected. Thanks, @alexsnaps!

@alexsnaps alexsnaps merged commit d0a32df into main Aug 27, 2024
14 checks passed
@alexsnaps alexsnaps deleted the v1beta2_hub branch August 27, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AuthConfig v1beta2 stored in etcd
2 participants