feat: added dokka templates directory for kotlinlang #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berezinant
force-pushed
the
ktl-1576-kotlinlang-api-ref
branch
from
3837955
to
20ce356
Compare
berezinant
force-pushed
the
ktl-1576-kotlinlang-api-ref
branch
from
20ce356
to
9f4b123
Compare
fzhinkin
requested changes
Sep 12, 2024
There was a problem hiding this comment.
@berezinant thank you for working on docs publication!
There are a few minor changes that could slightly improve build scripts, but otherwise the change looks good.
| @@ -44,3 +44,6 @@ kover { | |||
| } | |||
| } | |||
| } | |||
| tasks.dokkaHtmlMultiModule { | |||
| pluginsMapConfiguration.set(mapOf("org.jetbrains.dokka.base.DokkaBase" to """{ "templatesDir" : "${projectDir.toString().replace('\\', '/')}/dokka-templates" }""")) | |||
There was a problem hiding this comment.
Suggested change
| pluginsMapConfiguration.set(mapOf("org.jetbrains.dokka.base.DokkaBase" to """{ "templatesDir" : "${projectDir.toString().replace('\\', '/')}/dokka-templates" }""")) | |
| pluginsMapConfiguration.set(mapOf("org.jetbrains.dokka.base.DokkaBase" to """{ "templatesDir" : "${projectDir.resolve("dokka-templates")}" }""")) |
Or there's a reason to manually replace backslashes?
| @@ -44,3 +44,6 @@ kover { | |||
| } | |||
| } | |||
| } | |||
| tasks.dokkaHtmlMultiModule { | |||
There was a problem hiding this comment.
Could you please move this config setup to kotlinx-io-dokka.gradle.kts too?
I guess, dokkaHtmlMultiModule would need to be replaced with withType(DokkaMultiModuleTask::class.java).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding kotlinx-io api reference to kotlinlang and we need to customise templates for that