Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add progress logs for loading block/index #592

Closed
wants to merge 1 commit into from
Closed

Conversation

smk762
Copy link

@smk762 smk762 commented Sep 2, 2023

image

Ported from DigiByte-Core/digibyte#141

Close if considered pointless :)

@ca333 ca333 requested a review from DeckerSU January 26, 2024 11:24
@DeckerSU
Copy link

That's not a bad idea, but we already have a better implementation in KomodoOcean (Komodo-Qt). This implementation doesn't spam the standard output (in my personal opinion, a daemon shouldn't spam the standard output; it should use debug.log for any messages instead) and uses a log. The total progress looks like this:

2023-11-07 16:10:59 [10%]...[20%]...[30%]...[40%]...[50%]...[60%]...[70%]...[80%]...[90%]...[100%]...[DONE].
2023-11-07 16:11:24 LoadBlockIndexDB: loaded guts
2023-11-07 16:11:39 LoadBlockIndexDB: last block file = 218
2023-11-07 16:11:39 LoadBlockIndexDB: last block file info: CBlockFileInfo(blocks=23907, size=127470485, heights=3641721...3665165, time=2023-10-21...2023-11-06)
2023-11-07 16:11:39 Checking all blk files are present...
2023-11-07 16:11:39 [10%]...[20%]...[30%]...[40%]...[50%]...[60%]...[70%]...[80%]...[90%]...[100%]...[DONE].

Therefore, I prefer to close this pull request for now and use the KomodoOcean's progress bar implementation in the main Komodo repository. I will open a new pull request for this later.

@DeckerSU DeckerSU closed this Jan 26, 2024
Copy link

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants