Permit rpc help even during warmup #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9023d48.
Mihailo: `changed vout order so it is comparing marker value instead of vout to destination value.`
fix chanelsCC test vouts
fix broken secret reveal test add rpc response validation refund check no longer depends on the vout number prevents test failure on different branches due to ChannelsCC changes
ChannelsCC test refactor
In some cases CCs throwing exception such as:
`{'error': {'code': -3, 'message': 'Amount out of range'}`
And in some cases errors responses forming manually, e.g.:
`{'error': {'code': -3, 'message': 'Amount out of range'}`
lets handle both options (thanks to @dimxy for advise)
…andl_patch cc errors better handling
sync research
run CI workflows every Monday
Workflows - fix pull_request events trigger
CC_Tokens test - fix error handling
sync research
remove mysql-server from gha worker
"fix" gha linux worker
sync cd linux deps with ci
sync dev -> research
Corrected hardfork timestamp to June14th
sync research
Added enter/leave critical section around TestBlockValidity call in BitcoinMiner()
…-komodo # Conflicts: # qa/pytest_komodo/basic/pytest_util.py
pytest_util: Fix typo: Coennction => Connection
fixed parsing of nft data
NFT data validation cc added
Update ci.yml files
Fixes for GitHub CI (MacOS mainly)
Minor fixes from cppcheck
jmjatlanta
force-pushed
the
jmj_help_during_warmup
branch
from
15e7753
to
a27b24c
Compare
|
@jmjatlanta plz if you get a chance sync this one up - changed the base to |
I added unrelated changes to this PR, mainly comments, which caused conflicts. I will create a new PR based on dev that will only contain the requested change. (See PR #452) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #432
This will allow the server to reply to the
helprpc call even if the server is not fully warmed up.NOTE: Implementations of new RPC functionality must assure that nothing is done if the help boolean is set to true.