Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.7.2 Release Candidate #2459

Merged
merged 25 commits into from
Jun 24, 2024
Merged

v0.7.2 Release Candidate #2459

merged 25 commits into from
Jun 24, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jun 21, 2024

Test all changes from the following PRs:

Also do full regression testing of each page of app to ensure recent changes have not had any unintended consequences.

@ShantanuSharma9873
Copy link
Collaborator

image
image
image
image
#2454 Fix. The change in the currency is reflecting at all the places.

@ShantanuSharma9873
Copy link
Collaborator

image
#2453 Fix. Extended to 8dp for all the Portfolio items.

@ShantanuSharma9873
Copy link
Collaborator

image
Before
image
After
#2455 Bug fix: Orderbook now correctly scrolls to the bottom when flipping pairs, changing pairs, switching buy/sell modes. Verified

@ShantanuSharma9873
Copy link
Collaborator

image
#2457 Fix

Copy link
Collaborator

@ShantanuSharma9873 ShantanuSharma9873 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the fixes, working fine

Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All updates made seem to be working correctly. The following items were tested:

  • Confirm that portfolio asset values are all 8 decimal places
  • Currency display is changed consistently across the platform according to FIAT setting as well as currency set in top menu.
  • Orderbook listings top and bottom are scrolled to match one another as close as possible in the following conditions:
    • flipping pair
    • changing pair
    • changing buy/sell mode
    • loading dex pro tab
  • "Show orders after placement" toggle-setting functions correctly, setting the orders tab to either display after making an order or staying on the chart tab accordingly.
  • Version is correctly updated to 0.7.2

@smk762 smk762 merged commit 056f76f into master Jun 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants