feat(tokens): custom token activation for evm and tendermint #2141
Conversation
| CoinConfWithProtocolError::ProtocolMissMatch { ticker, .. } => { | ||
| InitL2Error::Internal(format!("Protocol from request is not supported for {}", ticker)) | ||
| }, |
There was a problem hiding this comment.
nit: We might want to print out the two protocols here.
There was a problem hiding this comment.
This means that setting the protocol from a request is not supported for L2 as there is no custom tokens for L2, and we set it as none below. So no need to print out the protocol IMHO.
| from_config, | ||
| from_request | ||
| )] | ||
| ProtocolMissMatch { |
There was a problem hiding this comment.
typo: Mismatch, only a single s.
There was a problem hiding this comment.
fixed here 7e95c7f
| pub struct TendermintTokenProtocolInfo { | ||
| pub platform: String, | ||
| // Todo: can decimals be gotten from rpc call for custom tokens? |
There was a problem hiding this comment.
There is denoms_metadata endpoint available on tendermint, but I am not sure if it works with the custom tokens.
There was a problem hiding this comment.
Thanks for the hint, will give it a look.
| @@ -90,11 +91,13 @@ where | |||
| InitTokenError: From<Token::ActivationError>, | |||
| (Token::ActivationError, InitTokenError): NotEqual, | |||
| { | |||
| // Todo: we should check if the contract has been enabled before in case the user is re-enabling the coin using a different ticker | |||
There was a problem hiding this comment.
This sounds like an EVM specific logic, why checking it here?
There was a problem hiding this comment.
Just a misplaced todo, will move it to a better place.
| Err(err) => match protocol_from_request { | ||
| Some(protocol_from_request) => { | ||
| // Todo: Remove this once order matching using contract instead of ticker is implemented | ||
| conf["wallet_only"] = json::Value::Bool(true); | ||
| protocol_from_request | ||
| }, | ||
| None => { | ||
| return MmError::err(CoinConfWithProtocolError::CoinProtocolParseError { | ||
| ticker: coin.into(), | ||
| err, | ||
| }) | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
less confusing IMO
| Err(err) => match protocol_from_request { | |
| Some(protocol_from_request) => { | |
| // Todo: Remove this once order matching using contract instead of ticker is implemented | |
| conf["wallet_only"] = json::Value::Bool(true); | |
| protocol_from_request | |
| }, | |
| None => { | |
| return MmError::err(CoinConfWithProtocolError::CoinProtocolParseError { | |
| ticker: coin.into(), | |
| err, | |
| }) | |
| }, | |
| }, | |
| }; | |
| Err(err) => { | |
| let protocol_from_request = | |
| protocol_from_request.ok_or(CoinConfWithProtocolError::CoinProtocolParseError { | |
| ticker: coin.into(), | |
| err, | |
| })?; | |
| conf["wallet_only"] = json::Value::Bool(true); | |
| protocol_from_request | |
| }, |
There was a problem hiding this comment.
Fixed here 8c489cf
| @@ -104,6 +124,7 @@ impl From<BalanceError> for EnableTokenError { | |||
| #[derive(Debug, Deserialize)] | |||
| pub struct EnableTokenRequest<T> { | |||
| ticker: String, | |||
| protocol: Option<CoinProtocol>, | |||
There was a problem hiding this comment.
I guess we can call this custom_protocol?
There was a problem hiding this comment.
The protocol is not custom though. The token is what is custom.
| } | ||
| protocol_from_config | ||
| }, | ||
| Err(err) => match protocol_from_request { |
There was a problem hiding this comment.
Can we work at all if "protocol" is missing in the 'coins' file?
I can see all coins there have "protocol" defined.
There was a problem hiding this comment.
No, we can't enable a coin from config without a defined protocol.
… `token_conf` parameter instead
No description provided.