feat(zcoin): implement zcoin/pirate transport layer for WASM #1996

borngraced · 2023-10-20T05:02:59Z

I've implemented a Zcoin transport layer that adheres to a common interface shared with the native transport. Additionally, I introduced helper functions within the FetchRequest and performed some refactoring in the mm2_net module

`ZCoin` activation on the web

Signed-off-by: borngraced <[email protected]>

# Conflicts: # Cargo.lock # mm2src/coins/Cargo.toml # mm2src/coins/z_coin/storage/walletdb/wasm/storage.rs # mm2src/coins/z_coin/z_rpc.rs # mm2src/mm2_main/src/wasm_tests.rs # mm2src/mm2_net/Cargo.toml # mm2src/mm2_net/src/lib.rs # mm2src/mm2_test_helpers/src/for_tests.rs

Signed-off-by: borngraced <[email protected]>

laruh

Thanks, next iteration. some notes + one question

mm2src/coins/z_coin/z_params/mod.rs

mm2src/coins/z_coin/z_params/indexeddb.rs

laruh · 2023-11-27T10:56:33Z

mm2src/coins/z_coin/z_params/mod.rs

+/// Download, validate and return z_params from given `DOWNLOAD_URL`
+async fn fetch_params(name: &str, expected_hash: &str) -> MmResult<Vec<u8>, ZcashParamsBytesError> {
+    let (status, file) = FetchRequest::get(&format!("{DOWNLOAD_URL}/{name}"))
+        .cors()


we dont use cors() for FetchRequest::get. Did you test it without cors?

doesn't work too.

Tests fail without cors call?

cors() doesn't fix cors issues with the server until the server was updated to allow all origin..so there's no reason to use it.

I think we should remove cors() then, if it doesnt change the situation.
Plus, I also used cors() in get req long time ago for nft, and GUI got some error on their side, after cors deletion error has gone.
As far as I remember there is no need to add cors in get req, browser does it itself.

@borngraced I have a question, did you check fetch_params process with react-komodefi-wasm project? Everything was fine in logs?

No, I didn't test with [react-komodefi-wasm](https://github.com/KomodoPlatform/react-komodefi-wasm) yet. But I'll do that today.

seems to be working as supposed

Ok, if no cors issues in console, then fine

Signed-off-by: borngraced <[email protected]>

laruh

Some more notes

mm2src/coins/z_coin/z_params/indexeddb.rs

Signed-off-by: borngraced <[email protected]>

laruh

Thanks, one more note

mm2src/coins/z_coin/z_params/indexeddb.rs

Signed-off-by: borngraced <[email protected]>

laruh

Thanks, LGTM!

Signed-off-by: borngraced <[email protected]>

shamardy

Amazing work as always! Only 2 comments for now, will do one last review after this probably!

mm2src/mm2_net/Cargo.toml

mm2src/mm2_main/src/wasm_tests.rs

Signed-off-by: borngraced <[email protected]>

shamardy

Thanks for the fixes! Please fix wasm warnings of unused imports and fix conflicts!
Will probably do one final review round after this one!

mm2src/mm2_main/tests/mm2_tests/mod.rs

mm2src/mm2_main/tests/mm2_tests/z_coin_tests.rs

mm2src/coins/z_coin.rs

mm2src/mm2_net/src/wasm/http.rs

Signed-off-by: borngraced <[email protected]>

mm2src/mm2_main/tests/mm2_tests/z_coin_tests.rs

…ort-layer # Conflicts: # mm2src/coins/z_coin.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs

Signed-off-by: borngraced <[email protected]>

shamardy

Next Iteration :)

mm2src/coins/z_coin/z_params/indexeddb.rs

mm2src/mm2_net/src/wasm/body_stream.rs

Signed-off-by: borngraced <[email protected]>

mm2src/coins/z_coin/z_coin_errors.rs

Signed-off-by: borngraced <[email protected]>

shamardy

🔥

borngraced added 5 commits September 28, 2023 11:02

save dev state

bbbff8c

Signed-off-by: borngraced <[email protected]>

save dev state

36921f7

Signed-off-by: borngraced <[email protected]>

revert changes

287461c

Signed-off-by: borngraced <[email protected]>

save dev state

68cd852

Signed-off-by: borngraced <[email protected]>

save dev state — finish impl zcoin transport layer

4c7588e

Signed-off-by: borngraced <[email protected]>

borngraced added the in progress Changes will be made from the author label Oct 20, 2023

borngraced requested a review from shamardy October 20, 2023 05:02

borngraced self-assigned this Oct 20, 2023

borngraced added 2 commits October 20, 2023 06:09

minor changes

ae2f775

Signed-off-by: borngraced <[email protected]>

remove unused

1c95fa8

Signed-off-by: borngraced <[email protected]>

borngraced changed the title ~~feat(zcoin): implement zcoin/pirate transport layer~~ feat(zcoin): implement zcoin/pirate transport layer for WASM Oct 20, 2023

borngraced added 19 commits October 21, 2023 01:48

minor changes

3300927

Signed-off-by: borngraced <[email protected]>

some refactorings to TonicClient imp

1af5898

Signed-off-by: borngraced <[email protected]>

fix wasm clippy warnings

abb873e

Signed-off-by: borngraced <[email protected]>

activate_z_coin_light unit test wasm

25fa583

Signed-off-by: borngraced <[email protected]>

enable waasm compilation for zcoin activation

08f2f8d

Signed-off-by: borngraced <[email protected]>

update time crate

055c085

Signed-off-by: borngraced <[email protected]>

use now_sec from common crate

39ae872

Signed-off-by: borngraced <[email protected]>

add ZOMBIE_LIGHTWALLETD_WSS_URLS

e668aaa

Signed-off-by: borngraced <[email protected]>

use correct electrum ZOMBIE_ELECTRUMS_WSS url

1b615bf

Signed-off-by: borngraced <[email protected]>

impl temp TxProver for WASM

a95391d

Signed-off-by: borngraced <[email protected]>

use proxied lightwalletd url for test

9e1c565

Signed-off-by: borngraced <[email protected]>

fix blockdb get_latest_block

b45fe2a

Signed-off-by: borngraced <[email protected]>

log activation info

503f769

Signed-off-by: borngraced <[email protected]>

fix query_blocks_by_limit block retrieval

adc053d

Signed-off-by: borngraced <[email protected]>

use init_z_coin_light_with_short_height

3ab3838

Signed-off-by: borngraced <[email protected]>

fix conflicts

d4c047c

Signed-off-by: borngraced <[email protected]>

fix wasm unit test query_blocks_by_limit

ba50185

Signed-off-by: borngraced <[email protected]>

additional fixes for query_blocks_by_limit

a2040b0

Signed-off-by: borngraced <[email protected]>

fix review notes

e468990

Signed-off-by: borngraced <[email protected]>

laruh requested changes Nov 27, 2023

View reviewed changes

make struct and fn pub(crate)

f2995bc

Signed-off-by: borngraced <[email protected]>

laruh requested changes Nov 29, 2023

View reviewed changes

fix review notes

a6ca1c7

Signed-off-by: borngraced <[email protected]>

laruh requested changes Dec 1, 2023

View reviewed changes

mm2src/coins/z_coin/z_params/indexeddb.rs Outdated Show resolved Hide resolved

fix review notes

2eecc9f

Signed-off-by: borngraced <[email protected]>

laruh approved these changes Dec 5, 2023

View reviewed changes

test ccursor forget

93e76c5

Signed-off-by: borngraced <[email protected]>

shamardy requested review from shamardy and removed request for shamardy December 5, 2023 18:20

borngraced added 2 commits December 5, 2023 23:01

continue debug indexeddb cursor

da09c4c

Signed-off-by: borngraced <[email protected]>

improve z_params impl

4c03c61

Signed-off-by: borngraced <[email protected]>

shamardy reviewed Dec 15, 2023

View reviewed changes

mm2src/mm2_net/Cargo.toml Outdated Show resolved Hide resolved

mm2src/mm2_main/src/wasm_tests.rs Outdated Show resolved Hide resolved

borngraced added 3 commits December 18, 2023 14:42

refactor body_stream and remove wasm-stream dep

1d89f45

Signed-off-by: borngraced <[email protected]>

read all stream instead of single

2a64404

Signed-off-by: borngraced <[email protected]>

merge enable_z_coin_light unit test

5aa68bc

Signed-off-by: borngraced <[email protected]>

shamardy reviewed Dec 21, 2023

View reviewed changes

mm2src/mm2_main/tests/mm2_tests/mod.rs Outdated Show resolved Hide resolved

mm2src/mm2_main/tests/mm2_tests/z_coin_tests.rs Outdated Show resolved Hide resolved

mm2src/coins/z_coin.rs Outdated Show resolved Hide resolved

mm2src/mm2_net/src/wasm/http.rs Outdated Show resolved Hide resolved

fix review notes

d775aec

Signed-off-by: borngraced <[email protected]>

shamardy reviewed Dec 21, 2023

View reviewed changes

mm2src/mm2_main/tests/mm2_tests/z_coin_tests.rs Outdated Show resolved Hide resolved

borngraced added 2 commits December 21, 2023 20:09

Merge remote-tracking branch 'origin/zcoin_storage' into zcoin-transp…

b9ec444

…ort-layer # Conflicts: # mm2src/coins/z_coin.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs

fix merge conflicts

2300d5c

Signed-off-by: borngraced <[email protected]>

shamardy reviewed Dec 21, 2023

View reviewed changes

fix review notes

e976a6d

Signed-off-by: borngraced <[email protected]>

shamardy reviewed Dec 21, 2023

View reviewed changes

mm2src/coins/z_coin/z_coin_errors.rs Outdated Show resolved Hide resolved

borngraced added 2 commits December 21, 2023 22:41

remove MalfunctionedParamsData

00eefce

Signed-off-by: borngraced <[email protected]>

update enable_z_coin_light to accept starting date

f93b130

Signed-off-by: borngraced <[email protected]>

shamardy approved these changes Dec 22, 2023

View reviewed changes

shamardy merged commit 3d80b3a into zcoin_storage Dec 22, 2023
23 of 30 checks passed

shamardy deleted the zcoin-transport-layer branch December 22, 2023 03:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(zcoin): implement zcoin/pirate transport layer for WASM #1996

feat(zcoin): implement zcoin/pirate transport layer for WASM #1996

borngraced commented Oct 20, 2023 •

edited

Loading

laruh left a comment

laruh Nov 27, 2023

borngraced Nov 28, 2023

laruh Nov 28, 2023

borngraced Nov 29, 2023

laruh Nov 29, 2023

laruh Dec 5, 2023

borngraced Dec 5, 2023

borngraced Dec 5, 2023

laruh Dec 5, 2023 •

edited

Loading

laruh left a comment

laruh left a comment

laruh left a comment

shamardy left a comment

shamardy left a comment

shamardy left a comment

shamardy left a comment

feat(zcoin): implement zcoin/pirate transport layer for WASM #1996

feat(zcoin): implement zcoin/pirate transport layer for WASM #1996

Conversation

borngraced commented Oct 20, 2023 • edited Loading

ZCoin activation on the web

laruh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

laruh Dec 5, 2023 • edited Loading

Choose a reason for hiding this comment

laruh left a comment

Choose a reason for hiding this comment

laruh left a comment

Choose a reason for hiding this comment

laruh left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

borngraced commented Oct 20, 2023 •

edited

Loading

`ZCoin` activation on the web

laruh Dec 5, 2023 •

edited

Loading