feat(adex-cli): provide activation request types to prevent malicious… #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… intents when activation scheme is being used
rozhkovdmitrii
force-pushed
the
feature-1682-interoperating
branch
from
89bf07c
to
1b9ba98
Compare
onur-ozkan
reviewed
Jul 12, 2023
shamardy
reviewed
Jul 12, 2023
rozhkovdmitrii
force-pushed
the
feature-1682-interoperating
branch
from
ef5724b
to
92a429c
Compare
rozhkovdmitrii
force-pushed
the
feature-1682-interoperating
branch
from
40fc116
to
98101ee
Compare
shamardy
previously approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Only a few non-blockers! Please merge with latest dev to fix conflicts and pass the adex-cli failing tests.
I will also not merge this PR until @Alrighttt approval, it can wait to v1.0.7-beta too.
added 2 commits
July 19, 2023 22:18
# Conflicts: # mm2src/adex_cli/src/tests/mod.rs
…t comply to mm2 - fixed
shamardy
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial comment: #1871 (comment)
Activation types have been introduced to be sure if the malicious person substituted them in the activation scheme file it would not lead to an unexpected action.