Fix #295 - sortService fails when sorting by date

Undefined variable dateRE is used instead of window.kg.sortService.dateRE
Knockout-Contrib · Mar 15, 2015 · 38e5632 · 38e5632
1 parent efde390
commit 38e5632
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/dist/KoGrid.js b/dist/KoGrid.js
@@ -2029,7 +2029,7 @@ window.kg.sortService = {
             d = '0' + d;
         }
         dateA = y + m + d;
-        mtch = b.match(dateRE);
+        mtch = b.match(window.kg.sortService.dateRE);
         y = mtch[3];
         d = mtch[2];
         m = mtch[1];
@@ -2101,7 +2101,6 @@ window.kg.sortService = {
             }
         });
         data(unwrappedData);
-        return;
     },
     Sort: function (sortInfo, data) {
         if (window.kg.sortService.isSorting) {

diff --git a/dist/KoGrid.min.js b/dist/KoGrid.min.js
diff --git a/dist/KoGrid.min.js.map b/dist/KoGrid.min.js.map
diff --git a/src/classes/sortService.js b/src/classes/sortService.js
@@ -164,7 +164,7 @@
             d = '0' + d;
         }
         dateA = y + m + d;
-        mtch = b.match(dateRE);
+        mtch = b.match(window.kg.sortService.dateRE);
         y = mtch[3];
         d = mtch[2];
         m = mtch[1];
@@ -236,7 +236,6 @@
             }
         });
         data(unwrappedData);
-        return;
     },
     Sort: function (sortInfo, data) {
         if (window.kg.sortService.isSorting) {