Fix #598 - required rule does not validate properly for boolean values

Closes #600
Knockout-Contrib · Jan 25, 2016 · f36ce9a · f36ce9a
1 parent 4e38dfa
commit f36ce9a
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 7 deletions.
diff --git a/dist/knockout.validation-with-locales.js b/dist/knockout.validation-with-locales.js
@@ -740,7 +740,7 @@ kv.rules['required'] = {
 	validator: function (val, required) {
 		var testVal;
 
-		if (val === undefined || val === null) {
+		if (val === undefined || val === null || val === false) {
 			return !required;
 		}
 

diff --git a/dist/knockout.validation-with-locales.min.js b/dist/knockout.validation-with-locales.min.js
diff --git a/dist/knockout.validation-with-locales.min.js.map b/dist/knockout.validation-with-locales.min.js.map
diff --git a/dist/knockout.validation.js b/dist/knockout.validation.js
@@ -740,7 +740,7 @@ kv.rules['required'] = {
 	validator: function (val, required) {
 		var testVal;
 
-		if (val === undefined || val === null) {
+		if (val === undefined || val === null || val === false) {
 			return !required;
 		}
 

diff --git a/dist/knockout.validation.min.js b/dist/knockout.validation.min.js
diff --git a/dist/knockout.validation.min.js.map b/dist/knockout.validation.min.js.map
diff --git a/src/rules.js b/src/rules.js
@@ -24,7 +24,7 @@ ko.validation.rules['required'] = {
 	validator: function (val, required) {
 		var testVal;
 
-		if (val === undefined || val === null) {
+		if (val === undefined || val === null || val === false) {
 			return !required;
 		}
 

diff --git a/test/rules-tests.js b/test/rules-tests.js
@@ -16,6 +16,11 @@ QUnit.test('Object is NOT Valid and isValid returns False', function(assert) {
 	assert.violatesRequiredRule(testObj, '');
 });
 
+QUnit.test('Issue #598 - "false" is NOT valid and isValid returns false', function(assert) {
+	var testObj = ko.observable(false).extend({ required: true });
+	assert.violatesRequiredRule(testObj, false);
+});
+
 QUnit.test('Zero is a valid value for required', function(assert) {
 	var testObj = ko.observable(0).extend({ required: true });
 	assert.observableIsValid(testObj, 0);