Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Refactor Looking Glass WebXR support #2959

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Nov 15, 2023

Context

Working branch to separate general WebXR behavior from behavior specific to the Looking Glass WebXR polyfill for holographic rendering.

I do not expect to have bandwidth to revisit this work. Others are welcome to pick up this draft PR and carry it to completion. Or, project maintainers are welcome to close the draft PR if it is determined that these changes will not be pursued.

Results

Changes

  • Adds vtkWebXRLookingGlassRenderWindowHelper subclass for behavior specific to the Looking Glass WebXR polyfill
  • Refactors vtkWebXRRenderWindowHelper to expose getRendererViewport method for subclass override. For instance, the Looking Glass display can override the method to indicate what quilt patch should be drawn for a given view.
  • Includes experiments for on-demand Looking Glass rendering, but further efforts would require resolution for Feature Request: Persist Last Rendered Hologram Looking-Glass/looking-glass-webxr#41
  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

fyi @floryst

@tbirdso tbirdso changed the title Draft: Looking glass specifics Draft: Refactor Looking Glass WebXR support Nov 15, 2023
@tbirdso tbirdso mentioned this pull request Nov 15, 2023
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant