fix(mapper): modify mapper when clearing clipping planes

Removing a clipping plane was modifying the mapper, while removing them all wasn't
Kitware · Aug 16, 2022 · 4209647 · 4209647
1 parent 62e5140
commit 4209647
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/Sources/Rendering/Core/AbstractMapper/index.d.ts b/Sources/Rendering/Core/AbstractMapper/index.d.ts
@@ -35,13 +35,15 @@ export interface vtkAbstractMapper extends vtkAbstractMapperBase {
 
 	/**
 	 * Remove all clipping planes.
+	 * @return true if there were planes, false otherwise.
 	 */
-	removeAllClippingPlanes(): void;
+	removeAllClippingPlanes(): boolean;
 
-	/**
-	 * Remove clipping plane.
-	 * @param {vtkPlane} plane
-	 */
+	 /**
+	  * Remove clipping plane.
+	  * @param {vtkPlane} plane
+	  * @return true if plane existed and therefore is removed, false otherwise.
+	  */
 	removeClippingPlane(plane: vtkPlane): boolean;
 
 	/**

diff --git a/Sources/Rendering/Core/AbstractMapper/index.js b/Sources/Rendering/Core/AbstractMapper/index.js
@@ -25,7 +25,12 @@ function vtkAbstractMapper(publicAPI, model) {
   publicAPI.getNumberOfClippingPlanes = () => model.clippingPlanes.length;
 
   publicAPI.removeAllClippingPlanes = () => {
+    if (model.clippingPlanes.length === 0) {
+      return false;
+    }
     model.clippingPlanes.length = 0;
+    publicAPI.modified();
+    return true;
   };
 
   publicAPI.removeClippingPlane = (clippingPlane) => {