refactor(remoteview): refactor constructor

refactor constructor to call setters at instanciation
Kitware · Jun 15, 2022 · 273158c · 273158c
1 parent 6e65814
commit 273158c
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/Sources/Rendering/Misc/RemoteView/index.js b/Sources/Rendering/Misc/RemoteView/index.js
@@ -187,21 +187,24 @@ function vtkRemoteView(publicAPI, model) {
 // Object factory
 // ----------------------------------------------------------------------------
 
-const DEFAULT_VALUES = {
-  viewId: '-1',
-  interactiveQuality: 60,
-  interactiveRatio: 1 / window.devicePixelRatio,
-  stillQuality: 100,
-  stillRatio: 1,
-  rpcMouseEvent: 'viewport.mouse.interaction',
-  rpcGestureEvent: null,
-  rpcWheelEvent: null,
-};
+function defaultValues(initialValues) {
+  return {
+    viewId: '-1',
+    interactiveQuality: 60,
+    interactiveRatio: 1 / window.devicePixelRatio,
+    stillQuality: 100,
+    stillRatio: 1,
+    rpcMouseEvent: 'viewport.mouse.interaction',
+    rpcGestureEvent: null,
+    rpcWheelEvent: null,
+    ...initialValues,
+  };
+}
 
 // ----------------------------------------------------------------------------
 
 export function extend(publicAPI, model, initialValues = {}) {
-  Object.assign(model, DEFAULT_VALUES, initialValues);
+  Object.assign(initialValues, defaultValues(initialValues));
 
   macro.obj(publicAPI, model, initialValues);
   macro.get(publicAPI, model, [