This repository has been archived by the owner on Aug 4, 2024. It is now read-only.

Replace failure with thiserror #52

Merged

KKould merged 2 commits into KipData:master from lewiszlw:this-error

Oct 13, 2023

Member

lewiszlw commented Oct 13, 2023

What problem does this PR solve?

failure is deprecated, replace it with thiserror.

What is changed and how it works?

Code changes

Has Rust code change
Has CI related scripts change

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Note for reviewer

lewiszlw added 2 commits

October 13, 2023 15:22


          Replace failure with thiserror

c3484bc


          Mark transparent for some errors

d2e3a06

KKould approved these changes

View reviewed changes

Member

KKould left a comment

lgtm

KKould merged commit 9399f64 into KipData:master

4 checks passed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet