-
Notifications
You must be signed in to change notification settings - Fork 746
Conversation
I am not sure that power out is the correct electrical type for sim_det Otherwise this looks good |
you are right, in the datasheet says input. thanks for catch |
Hi @jneiva08, thanks for contributing, A few comments additionally to @poeschlr :
Cheers, |
@myfreescalewebpage the footprint is found under KiCad/kicad-footprints#1099. And yes this link was missing from this pull request. |
I am sorry another merge caused a conflict in this PR due to KiCad updating the file version. @myfreescalewebpage about:
I think that the |
I resolved the conflict for you @jneiva08 Please make a pull before commiting any other changes! |
I agree. In the past someone ask me to add _N on a symbol to be consistent with the datasheet. I think he was right because when many pins have a similar name, this is a source of troubles. I think we should keep symbol closed to the datasheet. |
@antoniovazquezblanco and @jneiva08 just read KLC S4.7 (http://kicad-pcb.org/libraries/klc/S4.7/) and removed my previous comment about _N. Also make a second review of all the other PR I have commented these days, still some modifications to do to conform with this KLC. |
@antoniovazquezblanco Thanks for resolved the conflict. |
Add missing enddraw and enddef
Added missing "$endcmp"
Replace Integration Manual to datasheet
Sorry, I resolved the conflict through Github interface and missed those two lines! 🤦♂️ |
Is there anything missing in this PR? |
@antoniovazquezblanco there is question about the ANT pin, also on other PR (#748). Librarians haven't status actually. @jneiva08 I also just seen you should cross reference and name to be consistent with other devices : reference in top left corner, name in top right corner. Else, sounds good. |
Looks good now. |
thanks for all your time |
Added symbol of ublox Sara U2xxx
Datasheet: https://www.u-blox.com/sites/default/files/SARA-U2_DataSheet_(UBX-13005287).pdf
Integration Manual: https://www.u-blox.com/sites/default/files/SARA-G3-U2_SysIntegrManual_%28UBX-13000995%29.pdf
Footprint: #1099
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: