Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add switch C&K JS202011JCQN #2127

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Add switch C&K JS202011JCQN #2127

merged 2 commits into from
Mar 17, 2020

Conversation

mibe
Copy link
Contributor

@mibe mibe commented Mar 5, 2020

Add SMD DPDT switch C&K JS202011JCQN.
Datasheet (pg. 8 / 56)
Unbenannt

Pin 1 is bottom left as with the datasheet.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@poeschlr
Copy link
Collaborator

poeschlr commented Mar 6, 2020

Just because the datasheet shows the drawing in a particular direction does not negate the requirement of pin 1 being at the top left corner

@poeschlr poeschlr added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Mar 6, 2020
@mibe
Copy link
Contributor Author

mibe commented Mar 10, 2020

Well, F4.1 states that:

Where conflict exists between datasheet recommendations and KLC requirements, then (in the general case) the datasheet should take priority.
[...]
If the KLC is at odds with the datasheet, follow the datasheet, and note this difference to the KiCad library team when submitting your contribution.

Why is this not the case here?
The footprint could be rotated to show pin 1 at the top, though.

@chschlue
Copy link
Contributor

The datasheet doesn't recommend a specific orientation, it just happens to be drawn that way.
That's very different from a datasheet recommending a specific land pattern, for example.

@mibe
Copy link
Contributor Author

mibe commented Mar 11, 2020

Oh, I see. Thanks for the explanation!

@mibe
Copy link
Contributor Author

mibe commented Mar 11, 2020

Alright, I swapped the pad numbers. pin 1 is top left now.

@chmorgan chmorgan self-requested a review March 16, 2020 19:24
@chmorgan chmorgan self-assigned this Mar 16, 2020
Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pad sizes match datasheet recommendations
  • Any reason the pin numbering doesn't match the datasheet? You have 4, 5, 6, datasheet has 5, 6, 7.
  • Fab dimensions match datasheet
  • Pad positions and spacing are correct
  • Am I correct to assume that its ok to install the switch in any orientation as the center are the common pins?
  • Confirmed the part description contains the datasheet url.

@mibe
Copy link
Contributor Author

mibe commented Mar 16, 2020

* Any reason the pin numbering doesn't match the datasheet? You have 4, 5, 6, datasheet has 5, 6, 7.

In this case the pin numbers wouldn't match the symbol SW_DPDT_x2 of the Switch library.

* Am I correct to assume that its ok to install the switch in any orientation as the center are the common pins?

That is correct. The center pins are the common pins.

Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm courtyard spacing and pinout matches symbol.

@chmorgan chmorgan merged commit bb0d8a9 into KiCad:master Mar 17, 2020
@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Mar 17, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Mar 17, 2020
@ghost
Copy link

ghost commented Mar 17, 2020

At least in the screenshot there is no pin1 marker on silk or Fab.

@mibe
Copy link
Contributor Author

mibe commented Mar 21, 2020

That's true, there are no pin 1 markers.
Fab: F5.2: "Footprint polarisation / location of pin-1 is drawn": My interpretation was that this rule only applies to polarised parts. This part is not polarised, so I didn't draw the pin 1 marker.
Silk: The example pic for non polarised parts does not show the pin 1 designators, so I also omitted it on the silk screen.

@cpresser
Copy link
Contributor

We are discussing this rule (without result yet): KiCad/kicad-website#422

I would argue that this part is 'polarized'. In the sense that the switch has a default position. The datasheet has detailed drawings of the tape the and how the switches are oriented in the tape.

The Fab layer is intended to help the SMT operator loading the assembly machine. The silkscreen can be used to check proper orientation. Unless there is a mark they might put the switch on the board in any direction.
This will be really annoying for AOI or any kind of test that relies on a default NC/NO position of the switch.

@mibe mibe deleted the CK_JS202011JCQN branch May 12, 2020 23:22
@mibe mibe restored the CK_JS202011JCQN branch June 18, 2020 21:45
@mibe mibe deleted the CK_JS202011JCQN branch June 18, 2020 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants