Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/event display text #925

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Conversation

UberWaffe
Copy link
Collaborator

feat: Actions and conditions as sentences
In the event editor window will now display the actions and conditions as more human readable sentences. (As far as possible, not everything reads like a proper sentence.)

Requires PR #924

@UberWaffe
Copy link
Collaborator Author

Don't review this yet. I'll have to rebase this soon so I can include the actions and conditions from the now merged PR.

@UberWaffe UberWaffe marked this pull request as ready for review August 1, 2023 17:08
@UberWaffe
Copy link
Collaborator Author

@crudelios Allright, I've rebased it and included the actions and conditions from the previously merged PR.

Copy link
Collaborator

@crudelios crudelios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment.

src/scenario/scenario_events_parameter_data.c Outdated Show resolved Hide resolved
@UberWaffe
Copy link
Collaborator Author

@crudelios Updated with your comment.

@crudelios crudelios merged commit eea33a1 into Keriew:master Aug 3, 2023
14 checks passed
@UberWaffe UberWaffe deleted the feat/event_display_text branch August 3, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants