Fixes #37899 - Send proper EnvironmentDTO from hypervisors #11178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
force-pushed
the
37899-hypervisor-porpoise
branch
from
0888119
to
d426d3e
Compare
ianballou
reviewed
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Send Candlepin properly-formatted environment lists on consumer update, even for hosts with no content facet. Apparently hypervisors can hit this.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Set up a virt-who hypervisor
(To fake it, I think you could also just take a regular host and delete its content facet but leave its subscription facet.)
Go to All Hosts > your hypervisor > Overview tab > System Purpose card
Attempt to set any syspurpose attribute.
You should no longer get an error.