Fixes #37881 - Update global reg form for multi-env AKs and clean up loose ends #11169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthaa
reviewed
Oct 4, 2024
| @@ -7,7 +7,7 @@ def plugin_data | |||
| aks = ActivationKey.authorized(:view_activation_keys) | |||
| .where(organization_id: registration_params[:organization_id]) | |||
| .order(:name) | |||
| .map { |ak| { name: ak.name, lce: ak.environment&.name } } | |||
| .map { |ak| { name: ak.name, cves: ak.content_view_environments.map(&:label).join(', ') } } | |||
There was a problem hiding this comment.
Is the space after comma necessary ? does it work ?
There was a problem hiding this comment.
If you were copy/pasting to hammer with the spaces you'd need quotes. But this is just for displaying in the web UI, so I thought the spaces just looked nicer.
parthaa
reviewed
Oct 4, 2024
| @@ -26,8 +26,8 @@ child :content_view_environments => :content_view_environments do | |||
| lifecycle_environment_library: cve.lifecycle_environment&.library? | |||
| } | |||
| end | |||
| node :candlepin_name do |cve| | |||
There was a problem hiding this comment.
I 'd be nervous to do this for an api response. Can we may be have both ?
There was a problem hiding this comment.
The code that introduced this API response node was just merged today IIRC, so I don't think anyone relies on it yet. Thoughts?
|
Also updated the setting description since multiCV works with both hosts and AKs now. |
jeremylenz
changed the title
jeremylenz
force-pushed
the
37881-ak-global-reg
branch
from
4b37ae0
to
7c8b96a
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
candlepin_nameandcandlepin_namesmethods and method arguments tolabelsthroughout the Ruby codebase.Considerations taken when implementing this change?
This resolves the outstanding issues mentioned in #11161 (comment)
It also cleans up the loose end with the setting description, and eliminates a TODO comment.
What are the testing steps for this pull request?
This should affect these places in the UI - make sure everything works ok:
also, the method name changes affect multi-env hosts and AKs, so test some updates and make sure everything still works.