Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #37865 - Add multi cv env rabl to ak and turn off req for name #11166

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

chris1984
Copy link
Member

What are the changes introduced in this pull request?

  • Added multiple content view environments into the activation key base rabl, pulled in from Jeremy's WIP branch
  • Turned off name as a required param, since that broke host collections since it wanted a name and id
  • Moved the name param out of the param_group and put it back to just create/update where it was, Partha said this was an oversight when he worked on the support to add multiple envs to activation keys

What are the testing steps for this pull request?

@chris1984
Copy link
Member Author

Looks a lot better:

[DEBUG 2024-10-07T13:24:48 API] Response: {
                      "service_level" => nil,
                  "content_overrides" => [],
                                 "id" => 3,
                               "name" => "multi-key",
                        "description" => nil,
                    "unlimited_hosts" => true,
                        "auto_attach" => true,
    "content_view_environment_labels" => "Library/RHEL-8,Dev/Animals",
                        "usage_count" => 0,
                            "user_id" => 4,
                          "max_hosts" => nil,
                    "release_version" => nil,
                      "purpose_usage" => nil,
                       "purpose_role" => nil,
                    "organization_id" => 1,
                       "organization" => {
         "name" => "Default Organization",
        "label" => "Default_Organization",
           "id" => 1
    },
                         "created_at" => "2024-10-07 17:21:42 UTC",
                         "updated_at" => "2024-10-07 17:21:42 UTC",
          "content_view_environments" => [
        [0] {
                     "content_view" => {
                                         "id" => 2,
                                       "name" => "RHEL-8",
                                  "composite" => false,
                       "content_view_version" => "1.0",
                    "content_view_version_id" => 4,
                "content_view_version_latest" => true,
                       "content_view_default" => false
            },
            "lifecycle_environment" => {
                                           "id" => 1,
                                         "name" => "Library",
                "lifecycle_environment_library" => true
            },
                            "label" => "Library/RHEL-8"
        },
        [1] {
                     "content_view" => {
                                         "id" => 4,
                                       "name" => "Animals",
                                  "composite" => false,
                       "content_view_version" => "1.0",
                    "content_view_version_id" => 2,
                "content_view_version_latest" => true,
                       "content_view_default" => false
            },
            "lifecycle_environment" => {
                                           "id" => 2,
                                         "name" => "Dev",
                "lifecycle_environment_library" => false
            },
                            "label" => "Dev/Animals"
        }
    ],
                           "products" => [],
                   "host_collections" => [],
     "multi_content_view_environment" => true,
                    "content_view_id" => 2,
                       "content_view" => {
          "id" => 2,
        "name" => "RHEL-8"
    },
                     "environment_id" => 1,
                        "environment" => {
          "id" => 1,
        "name" => "Library"
    },
                     "purpose_addons" => [],
                        "permissions" => {
           "view_activation_keys" => true,
           "edit_activation_keys" => true,
        "destroy_activation_keys" => true
    }
}

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack from the functional side, name is no longer required if id is already provided, based on prt run in SatelliteQE/robottelo#16573

@chris1984 chris1984 merged commit 74e13f9 into Katello:master Oct 21, 2024
27 checks passed
@chris1984 chris1984 deleted the multiak branch October 21, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants