Refs #37785 - Race condition during container push #11162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Updates:
Refactor container push root creation into it's own action.
Acquire lock on product when saving container push root and repository.
Considerations taken when implementing this change?
Acquiring lock on product before saving root and repo makes sure only one worker can run the save! at a time even if we have multiple workers starting the create_root task at the exact same time.
What are the testing steps for this pull request?
What are the testing steps for this pull request?
Push a container image to katello.
Try multiple times till you see the race condition happen. It might take a few attempts to reproduce this.
On this branch, you shouldn't see the race condition causing a container push failure. You may see a logger statement when the race condition happens and the push should proceed as normal afterwards.