Fixes #37839 - bold skip dependency solving checkbox text #11151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianballou
force-pushed
the
37839-boldyboldbold
branch
from
b40ba5a
to
bd7ef94
Compare
sjha4
reviewed
Sep 19, 2024
| @@ -119,7 +119,7 @@ <h3 ng-show="errata" translate>Apply {{ errata.errata_id }}</h3> | |||
| <div class="checkbox" ng-show="updates.length > 0"> | |||
| <label> | |||
| <input name="noDepSolve" ng-model="noDepSolve" type="checkbox"/> | |||
| <span translate>Skip dependency solving for a significant speed increase. If the update cannot be applied to the host, delete the incremental content view version and retry the application with dependency solving turned on.</span> | |||
| <span translate><b>Skip dependency solving for a significant speed increase</b>. If the update cannot be applied to the host, delete the incremental content view version and retry the application with dependency solving turned on.</span> | |||
There was a problem hiding this comment.
Not a 100% sure if translation would work here..Maybe something like this?
....<span ...../>
There was a problem hiding this comment.
I see two options to fix this. Either I split up the string into a <b translate> block and a <span translate> block, or I just bold the entire thing.
Bolding the entire thing would change the look of course. Splitting it into two blocks would make the strings re-require retranslation.
Unless there's a potential fix that I'm not seeing where we can selectively bold and keep the translation string together?
ianballou
force-pushed
the
37839-boldyboldbold
branch
from
bd7ef94
to
4a13690
Compare
sjha4
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Bolds "Skip dependency solving for a significant speed increase" text when performing an incremental update via the UI.
Considerations taken when implementing this change?
Should all or some of the text be bold?
What are the testing steps for this pull request?
Try to apply some errata to a host that is applicable but not installable. Decide which looks better:
or