Skip to content

Commit

Permalink
Add TODO notes to check need for cpus-per-task flag
Browse files Browse the repository at this point in the history
- Check later if preplandobs and landanl APRUN commands
also need threading and therefore the --cpus-per-task flag.

Refs NOAA-EMC#2044
  • Loading branch information
KateFriedman-NOAA committed Nov 14, 2023
1 parent 4b492f4 commit 071ef94
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions env/ORION.env
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ if [[ "${step}" = "prep" ]] || [[ "${step}" = "prepbufr" ]]; then

elif [[ "${step}" = "preplandobs" ]]; then

export APRUN_CALCFIMS="${launcher} -n 1"
export APRUN_CALCFIMS="${launcher} -n 1" # TODO: Does this need threading (--cpus-per-task flag)?

elif [[ "${step}" = "waveinit" ]] || [[ "${step}" = "waveprep" ]] || [[ "${step}" = "wavepostsbs" ]] || \
[[ "${step}" = "wavepostbndpnt" ]] || [[ "${step}" = "wavepostpnt" ]] || [[ "${step}" == "wavepostbndpntbll" ]]; then
Expand Down Expand Up @@ -87,7 +87,7 @@ elif [[ "${step}" = "landanl" ]]; then
[[ ${NTHREADS_LANDANL} -gt ${nth_max} ]] && export NTHREADS_LANDANL=${nth_max}
export APRUN_LANDANL="${launcher} -n ${npe_landanl} --cpus-per-task=${NTHREADS_LANDANL}"

export APRUN_APPLY_INCR="${launcher} -n 6"
export APRUN_APPLY_INCR="${launcher} -n 6" # TODO: Does this need threading (--cpus-per-task flag)?

elif [[ "${step}" = "ocnanalbmat" ]]; then

Expand Down

0 comments on commit 071ef94

Please sign in to comment.