Add hide_button_when_fullscreen option #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might do some slight refactoring, but does it seem to work in its current form? |
|
Go ahead and modify as much as you like. I’ve been using it in its current form and or though I haven’t done exhaustive testing I’ve done some basic checking of different situations and it seems to work as expected. I put the code to make the button visible again in a fullscreen event rather than inside the toggleFullscreen since toggleFullscreen won’t be triggered for closing by using the esc key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero obligation to merge this but I wanted the option to have the button hide itself after entering full screen (it's for a tablet dashboard which I can't use the normal kiosk apps for due to the age of the hardware/os so I have to use chrome) and I figured I may as well open a PR to merge upstream in case anyone else thinks this might be useful.
Ta!